-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add limited_staff to allowedRoles [BB-7834] #2
fix: add limited_staff to allowedRoles [BB-7834] #2
Conversation
@0x29a, the change looks good to me, but I need to check something first, so I'll review this next week. We cannot use the Could it cause any trouble for the other client that uses this repo? |
@Agrendalath, I'm not that involved in the frontend development for this client, but I don't think it has any customizations that would conflict with the changes you're going to add. @navinkarkera, do you know if bumping @edx/frontend-platform version from 2.5.0 to ^4.2.0 (ae1702d) in the gradebook MFE can break something for ASU? |
@0x29a Unfortunately, I don't know. |
cc: @viadanna, as the client owner ^ |
I don't see a problem 👍 |
Backported from [here](openedx#352).
168cf24
to
25bdb04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: checked that the limited staff role can access gradebook
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository: n/a
I replaced the branches as described above. The original |
Backported from here.